From 6eba4aa52b097ea5403d7c9cd96e7b42430fb6e3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Cort=C3=A9s?= <hola@danielcortes.xyz>
Date: Fri, 9 Jul 2021 10:49:08 -0400
Subject: [PATCH] Error en la validacion de usuario

---
 .../app/Exceptions/InvalidUuidException.php   | 21 +++++++++++++++++++
 backend/app/Models/Usuario.php                |  6 +++---
 2 files changed, 24 insertions(+), 3 deletions(-)
 create mode 100644 backend/app/Exceptions/InvalidUuidException.php

diff --git a/backend/app/Exceptions/InvalidUuidException.php b/backend/app/Exceptions/InvalidUuidException.php
new file mode 100644
index 0000000..54f2ade
--- /dev/null
+++ b/backend/app/Exceptions/InvalidUuidException.php
@@ -0,0 +1,21 @@
+<?php
+
+namespace App\Exceptions;
+
+use Exception;
+
+class InvalidUuidException extends Exception {
+
+    protected $uuid;
+
+    public function __construct($uuid) {
+        $this->uuid = $uuid;
+    }
+
+    public function render($request) {
+        return response()->json([
+            'error' => 'invalid_uuid',
+            'message' => 'El id ' . $this->uuid . ' no es un UUID valido'
+        ], 400);
+    }
+}
diff --git a/backend/app/Models/Usuario.php b/backend/app/Models/Usuario.php
index 4c56511..804db47 100644
--- a/backend/app/Models/Usuario.php
+++ b/backend/app/Models/Usuario.php
@@ -23,12 +23,12 @@ class Usuario extends Model {
      * Busca un usuario o envia una excepcion si no se encuentra
      */
     public static function findOrFail($id) {
-        if (str_starts_with($id, 'auth0')) $usuario = Usuario::where('auth0_id', urldecode($id));
-        else $usuario = Usuario::where('id', $id);
+        if (str_starts_with($id, 'auth0')) $usuario = Usuario::where('auth0_id', urldecode($id))->first();
+        else $usuario = Usuario::where('id', $id)->first();
 
         if(!$usuario) throw new ModelNotFoundException("usuario", $id);
 
-        return $usuario->first();
+        return $usuario;
     }
 
     public function isGlobalAdmin() {