skrd/musiclist-server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

100% coverage en user api_views

Browse Source
This commit is contained in:
Daniel Cortes
2020-06-28 17:16:42 -04:00
parent 5183d5a65d
commit a1a46990c2
2 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
users/api_views.py
View File

@@ -8,9 +8,6 @@ from users.models import User, SocialNetworks
def user_view(request, user_id=None): def user_view(request, user_id=None):
if user_id is None:
return JsonResponse({'status': 400, 'error': 'No se entrego un user_id'}, status=400)
user = User.objects.filter(pk=user_id) user = User.objects.filter(pk=user_id)
if user.count() != 1: if user.count() != 1:
return JsonResponse({'status': 404, 'error': f'No existe un usuario con id {user_id}'}, status=404) return JsonResponse({'status': 404, 'error': f'No existe un usuario con id {user_id}'}, status=404)
@@ -51,9 +48,6 @@ def _put_user(request, user):
def social_networks_view(request, user_id=None): def social_networks_view(request, user_id=None):
if user_id is None:
return JsonResponse({'status': 400, 'error': 'No se entrego un user_id'}, status=400)
social_networks = SocialNetworks.objects.filter(user_id=user_id) social_networks = SocialNetworks.objects.filter(user_id=user_id)
if social_networks.count() != 1: if social_networks.count() != 1:
return JsonResponse({'status': 404, 'error': f'No existe redes sociales de un usuario con id {user_id}'}, return JsonResponse({'status': 404, 'error': f'No existe redes sociales de un usuario con id {user_id}'},

7
users/test.py
View File

@@ -111,13 +111,14 @@ class TestAPIViews(TestCase):
self.assertEqual(social_networks.youtube, new_social_data['youtube']) self.assertEqual(social_networks.youtube, new_social_data['youtube'])
self.assertEqual(social_networks.twitch, new_social_data['twitch']) self.assertEqual(social_networks.twitch, new_social_data['twitch'])
def test_put_social_networks_empty(self): def test_put_social_networks_invalid(self):
new_social_data = {} # max length para los fields es 255 => len('toolong'*37) == 259
new_social_data = {'twitter': 'toolong'*37}
response = self.client.put('/api/users/user/2/social_networks', json.dumps(new_social_data), response = self.client.put('/api/users/user/2/social_networks', json.dumps(new_social_data),
HTTP_AUTHORIZATION=self._user_header()) HTTP_AUTHORIZATION=self._user_header())
self.assertEqual(response.status_code, 200) self.assertEqual(response.status_code, 400)
def test_put_social_networks_not_modifying_self(self): def test_put_social_networks_not_modifying_self(self):
new_social_data = {} new_social_data = {}