skrd/musiclist-server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ultimos tests de cache

Browse Source
This commit is contained in:
Daniel Cortes
2020-06-14 04:08:18 -04:00
parent 71fe9523a9
commit a17d024393
2 changed files with 54 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fetcher/cache.py
View File

@@ -252,6 +252,7 @@ def get_cover_art_disc(mbid):
with get_redis_connection() as redis: with get_redis_connection() as redis:
covers = redis.get(f'release_group:{mbid}:cover_art') covers = redis.get(f'release_group:{mbid}:cover_art')
if not covers: if not covers:
jobs.load_entities_of_release_group.delay(mbid)
return None return None
return json.loads(covers) return json.loads(covers)
@@ -263,6 +264,7 @@ def get_cover_art_release(mbid):
with get_redis_connection() as redis: with get_redis_connection() as redis:
covers = redis.get(f'release:{mbid}:cover_art') covers = redis.get(f'release:{mbid}:cover_art')
if not covers: if not covers:
jobs.load_entities_of_release.delay(mbid)
return None return None
return json.loads(covers) return json.loads(covers)

52
fetcher/test.py
View File

@@ -876,3 +876,55 @@ class CacheTest(TestCase):
self.assertEquals(result, {'id': 'artist_id'}) self.assertEquals(result, {'id': 'artist_id'})
mock_jobs.load_entities_of_recording.delay.assert_not_called() mock_jobs.load_entities_of_recording.delay.assert_not_called()
@patch('fetcher.cache.jobs')
@patch('fetcher.cache.get_redis_connection')
def test_get_cover_art_disc_no_exists(self, mock_connection, mock_jobs):
"""Testear get cover art of disc cuando no existe"""
mock_redis = CacheTest.mock_redis(mock_connection)
mock_redis.get = Mock(return_value=None)
result = cache.get_cover_art_disc('mbid')
self.assertEquals(result, None)
mock_jobs.load_entities_of_release_group.delay.assert_called_with('mbid')
@patch('fetcher.cache.jobs')
@patch('fetcher.cache.get_redis_connection')
def test_get_cover_art_disc_exists(self, mock_connection, mock_jobs):
"""Testear get cover art of disc cuando no existe"""
mock_redis = CacheTest.mock_redis(mock_connection)
mock_redis.get = Mock(return_value=json.dumps({'id': 'mbid'}))
result = cache.get_cover_art_disc('mbid')
self.assertEquals(result, {'id': 'mbid'})
mock_jobs.load_entities_of_release_group.delay.assert_not_called()
@patch('fetcher.cache.jobs')
@patch('fetcher.cache.get_redis_connection')
def test_get_cover_art_release_no_exists(self, mock_connection, mock_jobs):
"""Testear get cover art of release cuando no existe"""
mock_redis = CacheTest.mock_redis(mock_connection)
mock_redis.get = Mock(return_value=None)
result = cache.get_cover_art_release('mbid')
self.assertEquals(result, None)
mock_jobs.load_entities_of_release.delay.assert_called_with('mbid')
@patch('fetcher.cache.jobs')
@patch('fetcher.cache.get_redis_connection')
def test_get_cover_art_release_exists(self, mock_connection, mock_jobs):
"""Testear get cover art of disc cuando no existe"""
mock_redis = CacheTest.mock_redis(mock_connection)
mock_redis.get = Mock(return_value=json.dumps({'id': 'mbid'}))
result = cache.get_cover_art_release('mbid')
self.assertEquals(result, {'id': 'mbid'})
mock_jobs.load_entities_of_release.delay.assert_not_called()