PLACEHOLDER ALL THE THINGS

This commit is contained in:
Daniel Cortes
2020-06-16 03:33:23 -04:00
parent 049f7e83d7
commit 2639427779
4 changed files with 23 additions and 17 deletions

View File

@@ -5,6 +5,7 @@ export const Entity = (props) => {
const hasCover = props.cover; const hasCover = props.cover;
const hasTags = props.tags && props.tags.length > 0; const hasTags = props.tags && props.tags.length > 0;
const hasButton = props.onButtonClick || props.buttonText const hasButton = props.onButtonClick || props.buttonText
return ( return (
<div className='entity'> <div className='entity'>
<div> <div>

View File

@@ -4,9 +4,9 @@ import "./EntityList.scss"
const EntityPlaceholder = (props) => { const EntityPlaceholder = (props) => {
return ( return (
<li className='entity-item pulsating'> <li className={'entity-item ' + (props.cover ? '' : 'pulsating')}>
<Link to={props.link}> <Link to={props.link}>
{props.cover && <div className='cover'/>} {props.cover && <div className='cover pulsating'/>}
<div className='body'> <div className='body'>
<span class='title'>&nbsp;</span> <span class='title'>&nbsp;</span>
<span className='subtitle'>&nbsp;</span> <span className='subtitle'>&nbsp;</span>

View File

@@ -17,8 +17,9 @@ const Discs = (props) => {
props.onPageChanged(page); props.onPageChanged(page);
} }
let discsComponent = <Fragment/>; let discsComponent = <EntityList placeholder={true} size={16} cover={true} grid={true}/>;
if (discs) { if (discs) {
if(discs.length > 0){
const items = discs.map((disc) => ({ const items = discs.map((disc) => ({
'cover': <CoverArt disc={disc}/>, 'cover': <CoverArt disc={disc}/>,
'link': `/disc/${disc.id}`, 'link': `/disc/${disc.id}`,
@@ -26,6 +27,9 @@ const Discs = (props) => {
'subtitle': disc.artist.name 'subtitle': disc.artist.name
})); }));
discsComponent = <EntityList items={items} grid={true}/> discsComponent = <EntityList items={items} grid={true}/>
}else{
discsComponent = <p>El artista no tiene discos</p>
}
} }
let paginateContent; let paginateContent;
@@ -54,9 +58,9 @@ const Artist = (props) => {
return <Entity title={artist.name} return <Entity title={artist.name}
subtitle={[artist.type, artist.country].filter(Boolean).join(' - ')} subtitle={[artist.type, artist.country].filter(Boolean).join(' - ')}
tags={artist.tags.map((tag) => (tag.name))} tags={artist.tags.map((tag) => (tag.name))}
buttonText='Agregar a mi list'/> buttonText='Agregar a mi lista'/>
}else { }else {
return <Fragment></Fragment> return <Fragment/>
} }
} }

View File

@@ -12,7 +12,6 @@ const capitalize = (string) => {
return string.charAt(0).toUpperCase() + string.slice(1); return string.charAt(0).toUpperCase() + string.slice(1);
} }
const Versions = (props) => { const Versions = (props) => {
const versions = props.versions ? props.versions : null; const versions = props.versions ? props.versions : null;
const paginate = props.paginate ? props.paginate : null; const paginate = props.paginate ? props.paginate : null;
@@ -21,7 +20,7 @@ const Versions = (props) => {
props.onPageChanged(page); props.onPageChanged(page);
} }
let versionsComponent = <Fragment/>; let versionsComponent = <EntityList placeholder={true} size={10} cover={true}/>;
if(versions) { if(versions) {
const items = versions.map((version) => ({ const items = versions.map((version) => ({
'cover': <CoverArt release={version}/>, 'cover': <CoverArt release={version}/>,
@@ -105,9 +104,11 @@ export const DiscView = (props) => {
return ( return (
<Fragment> <Fragment>
<Disc disc={disc}/> <Disc disc={disc}/>
{disc &&
<Versions versions={versions} paginate={versionsPaginate} <Versions versions={versions} paginate={versionsPaginate}
onPageChanged={handleVersionPageChanged} makeLink={makeLink} onPageChanged={handleVersionPageChanged} makeLink={makeLink}
navigateToVersion={handleNavigateToVersion}/> navigateToVersion={handleNavigateToVersion}/>
}
</Fragment> </Fragment>
) )
} }